Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with github commandline tool for release creation #230

Closed
2 tasks
sunng87 opened this issue Oct 14, 2020 · 6 comments
Closed
2 tasks

Integrate with github commandline tool for release creation #230

sunng87 opened this issue Oct 14, 2020 · 6 comments
Assignees
Labels
question Uncertainty is involved

Comments

@sunng87
Copy link
Collaborator

sunng87 commented Oct 14, 2020

The github command line tool provides a release command to create a github release. It would be nice if you optionally support it in our process.

Related topics:

@sunng87 sunng87 added the enhancement Improve the expected label Oct 14, 2020
@sunng87 sunng87 self-assigned this Oct 19, 2020
@sunng87 sunng87 added this to the 0.14 milestone Oct 19, 2020
@epage
Copy link
Collaborator

epage commented Oct 19, 2020

Is #201 a pre-req? It seems like that should be the responsibility of the user's CI to update the release with the artifacts. Most people can't create all artifacts from the one machine doing cargo-release

@sunng87
Copy link
Collaborator Author

sunng87 commented Oct 20, 2020

@epage right, I think it's an optional one. Most binaries are platform dependent so the workflow should be using gh release upload to upload them individually.

I just changed prerequisites to related topics to clarify.

@CleanCut
Copy link

I would love this functionality even without any binary artifact handling.

@epage
Copy link
Collaborator

epage commented Jul 2, 2021

For those interested, for now I've taken to creating the release, with notes, via Github Actions

See crate-ci/typos@5c92dc6

@CleanCut
Copy link

CleanCut commented Jul 2, 2021

@epage Thanks for sharing!

@epage epage removed this from the 0.14 milestone Aug 23, 2021
@epage epage added question Uncertainty is involved and removed enhancement Improve the expected labels Aug 25, 2021
@epage epage closed this as completed in b45e6c1 Oct 19, 2022
@epage
Copy link
Collaborator

epage commented Oct 19, 2022

Decided to handle this by documenting it in the FAQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Uncertainty is involved
Projects
None yet
Development

No branches or pull requests

3 participants