Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a special situation in my project, where I'm using fireworks-js, where I needed to detect whenever a firework explodes.
One possible way to achieve this is by pre-calculating when a certain firework will explode, which is kinda difficult and not reliable, because it highly depends on the number of animation frames.
The way I handled it in the
update
function is kinda unorthodox, since it is being run inside an animation frame, but it's the easiest way to achieve this.I also added an example usage to /examples/basic/.
I created this PR as a draft first, since I'd like to first discuss if it's even a good idea.
This is not a breaking change in any way and shouldn't be hard at all to maintain, so I don't think it has any downsides.
This also created a base for easily implementing even more custom events in the future.
One todo would maybe be to include the coordinates in the event at what place the firework exploded.
Checklist
pnpm format
and the Code of conduct