ci: add tests workflow #120
Conversation
ee7
force-pushed
the
ee7/ci-add-tests-workflow
branch
2 times, most recently
from
e68fafb to
2b24f18
Compare
ee7
force-pushed
the
ee7/ci-add-tests-workflow
branch
from
2b24f18 to
da81cc3
Compare
ee7
force-pushed
the
ee7/ci-add-tests-workflow
branch
from
ec35eff to
4169a32
Compare
ee7
force-pushed
the
ee7/ci-add-tests-workflow
branch
3 times, most recently
from
267cd8d to
8200a9e
Compare
.github/workflows/tests.yml
Outdated
| run: nimble build | ||
|
|
||
| - name: Run tests | ||
| run: ./test || exit 0 # TODO: Stop allowing tests to fail. |
There was a problem hiding this comment.
Do tests fail now? Even if they do I think we can still merge prs until we fix all tests
There was a problem hiding this comment.
Yes, tests do fail now.
I'm OK with removing the || exit 0 and not requiring a PR that targets jtv/v2 in this repo to pass all checks before merging - then the check status actually reflects the tests. However, currently the branch protection rule in this repo blocks this PR being merged.
For now, make the workflow indicate success even if the tests fail. This workflow still asserts that `nimble build` succeeds, which it didn't until now on Linux.
This reverts the previous commit.
On macOS x86_64, the workflow errored with:
clang: error: no such file or directory: '/Users/runner/.local/c0/libs/libffi.a'
and on macOS arm64 it errored with:
ERROR: unable to find archive matching pattern macosx_arm64.tar.xz
because the nim nightlies repo doesn't have binary builds for that platform.
This reverts commit bc55af8.
ee7
force-pushed
the
ee7/ci-add-tests-workflow
branch
from
8200a9e to
683db8f
Compare
Bump to the latest release. See the new commits [1]. [1] actions/checkout@v4.1.1...v4.1.4
Bump to the latest release. See the new commits [1]. [1] iffy/install-nim@v5.0.3...v5.0.4
Be consistent with version comments in our workflows elsewhere.
|
@miki725 Following up from #120 (comment) and later discussion, our preference was for us to disable/bypass the branch protection rule that requires checks to succeed, and merge this PR as-is, right? If so, could you please disable the branch protection rule for |
|
v2 is not a protected branch. as such there are no merge requirements here |
|
|
Oh, sorry. I didn't notice that I could merge this - I guess I'm much too conditioned to needing the button to go green first.
|
Add a workflow that runs
nimble buildandtest.The tests currently fail,
so make the workflow indicate success even if the tests fail for now. This workflow is still useful because it ensures thatnimble buildsucceeds - that command errored on Linux until recently (#128).Closes #121
To-do:
jtv/v2branchjtv/v2devif we won't use that branch in the future