Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support all git pack object types #348

Open
miki725 opened this issue Jun 17, 2024 · 0 comments
Open

support all git pack object types #348

miki725 opened this issue Jun 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@miki725
Copy link
Contributor

miki725 commented Jun 17, 2024

Git has multiple pack object types:

https://git-scm.com/docs/pack-format

Currently chalk can only understand either commit or tag object types however packed repos can store refs themselves as deltas. This means that if the repos HEAD points to such an object, chalk will not be able to understand it.

For example change:

git.symbolic_ref(f"refs/tags/foo/{random_hex}-2")

to use {random_hex}-1 tag and chalk will not report any git information at all.

Although implementing full delta spec which has multiple instructions is more complicated so probably worth looking into getting libgit into chalk as a dep.

@miki725 miki725 added the bug Something isn't working label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant