Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): IO safety violations while dropping the fd of open file #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(test): IO safety violations while dropping the fd of open file #2

wants to merge 1 commit into from

Conversation

WeepingClown13
Copy link

With stdlib changes File now uses OwnedFd internally that does IO safety checks in debug mode and that consequently causes the test here to panic as FDs of open files are closed behind stdlib's back. So this patch uses the low level libc::open to directly return a RawFd, skipping the std::fs::File::open calls and as_raw_fd conversion.

Fixes: #1

@WeepingClown13 WeepingClown13 changed the title fix(test): IO safety check violations while dropping the fd of an ope… fix(test): IO safety violations while dropping the fd of open file Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal runtime error: IO Safety violation: owned file descriptor already closed
1 participant
@WeepingClown13