Merge pull request #50 from cowprotocol/imbalances-schema

Fixed inconsistency in table schema
cowprotocol · Aug 29, 2024 · a897914 · a897914
2 parents a6eef14 + d5cc283
commit a897914
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 27 deletions.
diff --git a/src/helpers/database.py b/src/helpers/database.py
@@ -37,16 +37,6 @@ def execute_and_commit(self, query: str, params: dict):
                 connection.rollback()
                 raise
 
-    def record_exists(self, tx_hash: bytes, token_address: bytes) -> bool:
-        """
-        Function checks if an entry of (tx_hash, token) already exists in the token imbalances table.
-        """
-        query = read_sql_file("src/sql/select_record_exists.sql")
-        result = self.execute_query(
-            query, {"tx_hash": tx_hash, "token_address": token_address}
-        )
-        return result.fetchone() is not None
-
     def write_token_imbalances(
         self,
         tx_hash: str,
@@ -59,19 +49,18 @@ def write_token_imbalances(
         tx_hash_bytes = bytes.fromhex(tx_hash[2:])
         token_address_bytes = bytes.fromhex(token_address[2:])
 
-        if not self.record_exists(tx_hash_bytes, token_address_bytes):
-            query = read_sql_file("src/sql/insert_raw_token_imbalances.sql")
-            self.execute_and_commit(
-                query,
-                {
-                    "auction_id": auction_id,
-                    "chain_name": self.chain_name,
-                    "block_number": block_number,
-                    "tx_hash": tx_hash_bytes,
-                    "token_address": token_address_bytes,
-                    "imbalance": imbalance,
-                },
-            )
+        query = read_sql_file("src/sql/insert_raw_token_imbalances.sql")
+        self.execute_and_commit(
+            query,
+            {
+                "auction_id": auction_id,
+                "chain_name": self.chain_name,
+                "block_number": block_number,
+                "tx_hash": tx_hash_bytes,
+                "token_address": token_address_bytes,
+                "imbalance": imbalance,
+            },
+        )
 
     def write_prices(
         self,

diff --git a/src/sql/schema.sql b/src/sql/schema.sql
@@ -7,7 +7,8 @@ CREATE TABLE raw_token_imbalances (
     block_number BIGINT NOT NULL,
     tx_hash BYTEA NOT NULL,
     token_address BYTEA NOT NULL,
-    imbalance NUMERIC(78,0)
+    imbalance NUMERIC(78,0),
+    PRIMARY KEY (tx_hash, token_address)
 );
 
 -- Table: slippage_prices (for storing per unit token prices in ETH)

diff --git a/src/sql/select_record_exists.sql b/src/sql/select_record_exists.sql