Enable slippage calculations on Arbitrum and Gnosis Chain by default #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I remember correctly, the slippage query does not handle protocol fees (and network fees) correctly. Or rather, it handles those fees as if they were slippage. Which does not work correctly with the rest of the code which treats network and partner fees separately. Did you see that in testing? |
|
The required change to dune queries is cowprotocol/dune-queries#87. |
|
Closing as the change is implemented in PR #454 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables slippage calculations by default for Gnosis Chain and Arbitrum. Some preliminary testing suggests things work fine and since we want to do slippage accounting anyways, this PR addresses that