Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for service fee #428

Open
fhenneke opened this issue Nov 13, 2024 · 0 comments
Open

Add tests for service fee #428

fhenneke opened this issue Nov 13, 2024 · 0 comments

Comments

@fhenneke
Copy link
Collaborator

PR #426 fixed a bug with service fee logs. To avoid unintentially reintroducing such a bug, we should add a test.

For example, we could test the property total_reward_cow() + reward_scaling() * quote_reward_cow + total_service_fee() == primary_reward_cow + quote_reward_cow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fhenneke