Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parts of slippage query #383

Open
fhenneke opened this issue Aug 15, 2024 · 0 comments
Open

Remove unused parts of slippage query #383

fhenneke opened this issue Aug 15, 2024 · 0 comments

Comments

@fhenneke
Copy link
Collaborator

The current slippage query has unused code:

  • There is a TokenList parameter and a token_list table, but they are never used.

,token_list as (
SELECT from_hex(address_str) as address
FROM ( VALUES {{TokenList}} ) as _ (address_str)
)

  • There are not internalized imbalances anymore so this part seems unnecessary (and the subsequent join)

or 0x413530a7beB9Ff6C44e9e6C9001C93B785420C32 in (buy_token_address, sell_token_address) -- exclude PFPAsia. NEEDS TO BE REMOVED FROM THIS LIST
or 0xe7468080c033cE50Dd09A22ad1E58D1BDA69E436 in (buy_token_address, sell_token_address) -- exclude YUMYUM. NEEDS TO BE REMOVED FROM THIS LIST

Removing the respective code should be relatively safe. Removing the parameter requires additional changes to how the query is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant