Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenwise Min Transfer Amount #314

Open
bh2smith opened this issue Jul 10, 2023 · 1 comment
Open

Tokenwise Min Transfer Amount #314

bh2smith opened this issue Jul 10, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@bh2smith
Copy link
Contributor

solver-rewards/src/utils/script_args.py

Lines 59 to 65 in c34757e

# TODO: this should be per token (like list[tuple[Token,minAmount]])
parser.add_argument(
"--min-transfer-amount-wei",
type=int,
help="Ignore transfers with amount less than this",
default=1000000000000000,
)

This runtime argument should be per token rather than just universal. Since ETH and COW both have different USD values we may want to have different min transfer thresholds.
@bh2smith bh2smith added the good first issue Good for newcomers label Jul 10, 2023
@bh2smith bh2smith mentioned this issue Jul 10, 2023
Merged
kobadmitrii added a commit to kobadmitrii/solver-rewards that referenced this issue Jul 11, 2023
@kobadmitrii
[cowprotocol#314] tuple of tokens instead of ETH only
0f3641b
kobadmitrii added a commit to kobadmitrii/solver-rewards that referenced this issue Jul 11, 2023
@kobadmitrii
Merge pull request #1 from kobadmitrii/issue-314
544f243 
[cowprotocol#314]  tuple of tokens instead of ETH only
@kobadmitrii
Copy link

I also made PR #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bh2smith @kobadmitrii