Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Driver should re-simulate all solutions on a new block #3069

Open
MartinquaXD opened this issue Oct 18, 2024 · 2 comments
Open

chore: Driver should re-simulate all solutions on a new block #3069

MartinquaXD opened this issue Oct 18, 2024 · 2 comments

Comments

@MartinquaXD
Copy link
Contributor

Background

A solver is allowed to return multiple solutions to the driver. The driver will then simulate, score and rank all the solutions and only remember the winning solution. Then on every new block it will check if the winning solution still works. That was done to prevent the driver promising solutions that would no longer work which would result in penalties for the connected solver.

Acceptance criteria

The current approach can lead to issues where on a new block only the best solutions starts reverting but not the other solutions provided by the solver. In that case the driver should pick the best still working solution of the bunch and not just invalidate the previously best solution and give up.

@shivamklr
Copy link

I think this requires a bit of a refactor. The /settle endpoint receives a solution_id from autopilot which should be different for each settlement. Else we can make auction_id mandatory and just execute the best available settlement for the given auction_id.

@sunce86
Copy link
Contributor

sunce86 commented Dec 5, 2024

I think you are right this is problematic. Driver shouldn't submit a solution different to the one that autopilot allowed it to settle based on the best score, otherwise the whole competition is useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants