Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fee policies retrievable for all orders in auction #3046

Open
sunce86 opened this issue Oct 9, 2024 · 1 comment
Open

feat: Fee policies retrievable for all orders in auction #3046

sunce86 opened this issue Oct 9, 2024 · 1 comment

Comments

@sunce86
Copy link
Contributor

sunce86 commented Oct 9, 2024

Problem

The last attempt to save fee policies for all orders in the auction didn't work as expected (see PR: #3011).

We need a more efficient way to store fee policies so that they can be retrieved for each order in each auction.

This is a requirement for Issue #2844.

Suggested solution

@fleupold proposed an incremental approach: store the fee policy for an order the first time it appears in an auction. If the fee policy doesn't change in subsequent auctions, skip saving it again. If it does change, save the updated policy. When retrieving the fee policy for Auction X, search backwards through previous auctions (X, X-1, etc.) until the relevant policy is found.

Alternatives considered

One alternative is to shift fee policy creation to the orderbook and link it directly to order creation. Although this would involve significantly more work, it’s worth investigating how much effort this would actually require before fully committing to the incremental approach.

Copy link

github-actions bot commented Dec 9, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the Stale label Dec 9, 2024
@sunce86 sunce86 removed the Stale label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant