Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve checking of commonly used tokens in autopilot competition #3043

Closed
sunce86 opened this issue Oct 9, 2024 · 0 comments · Fixed by #3074
Closed

chore: Improve checking of commonly used tokens in autopilot competition #3043

sunce86 opened this issue Oct 9, 2024 · 0 comments · Fixed by #3074
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Oct 9, 2024 •
edited
Loading

Background

Related to #3042 (comment)

Details

Currently ETH and WETH are considered different tokens, although there is a high chance that these two assets will use the same amm routes.

The logic for choosing the winner needs to treat them as a single token, so when one of them is detected as swapped, to automatically add other one to the already_swapped_tokens list.
@sunce86 sunce86 added the E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details label Oct 9, 2024
@sunce86 sunce86 mentioned this issue Oct 9, 2024
Merged
2 tasks
@sunce86 sunce86 mentioned this issue Oct 18, 2024
Merged
sunce86 added a commit that referenced this issue Oct 22, 2024
@sunce86
Treat ETH and WETH as single token in winners selection (#3074)
388486d 
# Description
Fixes #3043

Treats ETH and WETH as a same token in winner detection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat ETH and WETH as single token in winners selection cowprotocol/services
1 participant
@sunce86