Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Save multiple winners to database #3021

Closed
sunce86 opened this issue Sep 27, 2024 · 0 comments · Fixed by #2980
Closed

feat: Save multiple winners to database #3021

sunce86 opened this issue Sep 27, 2024 · 0 comments · Fixed by #2980
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Sep 27, 2024

Problem

Related to #2830 (comment)

This issue captures work around saving solve competition data to database, so that it supports multiple winners per auction.

Dependent on #2979 and #2980

@sunce86 sunce86 added the E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details label Sep 27, 2024
sunce86 added a commit that referenced this issue Oct 4, 2024
# Description
Fixes #2994
Fixes #2995
Fixes #2998

- [ ] Adds configuration parameter `max_winners_per_auction` to
enable/disable multiple winners feature.
- [ ] Chooses the winners based on the `max_winners_per_auction`.
- [ ] Then issues multiple settle calls for each of the winners.

The only remaining part to implement is competition saving but this is
captured with #3021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant