feat: Report and store all executed orders during bidding

[fhenneke]

Problem

At the moment, a solver can include orders in a settlement at will if the order is settled at limit price. Those orders need not be reported during bidding.

This is generally a problem for protecting users but will also be problematic with most forms of combinatorial auction or payments with multiple winners. For example, a solver might execute an additional order on a token pair having no tokens in common with the reported trades. A second winner might now execute on that same token pair.

Suggested solution

A first step towards creating more rigorous rules around settling orders out of competition would be to force solvers to report all orders which are executed to the autopilot.

Additional context

There is a general problem with executing orders which can capture surplus at limit price.

The feature of executing jit orders at limit price without reporting the order is only used in obscure cases. For example for CoW AMM JIT orders with missing native prices. The impact of removing the feature should be small.

[sunce86]

I assume that for these orders we don't have to require existence of native prices for tokens they swap?

[fleupold]

The reporting is already covered by #3001 isn't it? Now we also need to store those (even if they don't up landed)

[sunce86]

The reporting is already covered by #3001 isn't it? Now we also need to store those (even if they don't up landed)

No, #3001 only expanded the response for orders that were already reported (regular user orders and surplus capturing JIT orders). Driver still do not report non surplus capturing JIT orders. I also think this needs to be communicated to solvers in advance.

@fleupold can you move the issue status to To Do if you agree we should work on this.