Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update E2e::tests::database::most_recent_cip_20_data #2992

Closed
sunce86 opened this issue Sep 16, 2024 · 0 comments · Fixed by #2997
Closed

feat: Update E2e::tests::database::most_recent_cip_20_data #2992

sunce86 opened this issue Sep 16, 2024 · 0 comments · Fixed by #2997
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Sep 16, 2024

Problem

Related to #2830 (comment)

Function E2e::tests::database::most_recent_cip_20_data() needs to be updated in order to support multiple winners per auction.

Suggested solution

Still fetch all relevant data for an auction, it's just now it's possible to have multiple transactions associated to an auction, as well as settlement observations and scores.
@sunce86 sunce86 added the E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details label Sep 16, 2024
This was referenced Sep 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EASY] Update most_recent_cip_20_data cowprotocol/services
1 participant
@sunce86