Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Precheck token quality before it gets evicted from the cache #2929

Closed
MartinquaXD opened this issue Aug 28, 2024 · 2 comments
Closed

chore: Precheck token quality before it gets evicted from the cache #2929

MartinquaXD opened this issue Aug 28, 2024 · 2 comments
Labels
E:6.1 One auction per block See https://github.com/cowprotocol/pm/issues/35 for details

Comments

@MartinquaXD
Copy link
Contributor

Background

We already have a background task for the bad token test that updates expired tokens which improved the performance somewhat.
However, it still does not re-check and update the cache slightly before the items expire (similar to native token cache). This should resolve the last few problematic outliers in terms of runtime.
@fleupold
Copy link
Contributor

Likely similar logic is applied for the native price estimator here (under the concept "prefetch")

@fleupold fleupold added the E:6.1 One auction per block See https://github.com/cowprotocol/pm/issues/35 for details label Aug 30, 2024
@m-lord-renkse m-lord-renkse mentioned this issue Sep 4, 2024
Merged
@m-lord-renkse
Copy link
Contributor

Implemented in: #2936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:6.1 One auction per block See https://github.com/cowprotocol/pm/issues/35 for details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fleupold @MartinquaXD @m-lord-renkse