Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Revert commented out driver test #2511

Closed
sunce86 opened this issue Mar 11, 2024 · 0 comments · Fixed by #2563
Closed

chore: Revert commented out driver test #2511

sunce86 opened this issue Mar 11, 2024 · 0 comments · Fixed by #2563

Comments

@sunce86
Copy link
Contributor

sunce86 commented Mar 11, 2024

Background

For #2509 needs, I had to comment out one driver test that started failing all of a sudden between this and this action.

Few facts:

  1. The failure is not caused by code change, because there were several PRs that contained all the recent commits and passed successfully CI before 8th of March evening.
  2. I compared the tools used (in successful vs failed action run) and all dependencies are same:

Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
Download action repository 'foundry-rs/foundry-toolchain@v1' (SHA:362aa1be8f31305295acb1032271acd5e9b99312)
Download action repository 'Swatinem/rust-cache@v2' (SHA:23bce251a8cd2ffc3c1075eaa2367cf899916d84)
Download action repository 'taiki-e/install-action@nextest' (SHA:86942e25b57085bbdddea3ed90d56728b106b0aa)

Acceptance criteria

The driver test high_gas_limit is uncommented and passes CI.
@fleupold fleupold mentioned this issue Mar 24, 2024
Merged
2 tasks
fleupold added a commit that referenced this issue Mar 28, 2024
@fleupold
Reject too gas intensive solutions already in driver competition (#2563)
a5456a9 
# Description
#2526 started limiting the amount of gas the driver allows per solution.
However, the limit was only applied after solutions had been ranked and
participated in the autopilot's auction. This lead to large settlements
effectively clogging the auction cycle as solvers would continue to win
the competition but then fail to submit.

This PR filters out such solutions already in the driver internal
ranking phase so that too large settlements never participate as
solution candidate.

# Changes
- [x] Make `Gas::new` return an error if gas limit is too high
- [x] Introduce a new solver error type that solver engines are notified
about.

## How to test
Adjusted high gas limit driver test

## Related Issues

Fixes #2511 (or rather makes it obsolete)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reject too gas intensive solutions already in driver competition cowprotocol/services
1 participant
@sunce86