You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, units of config params with the Duration type are hard coded and being parsed using custom functions like duration_from_seconds. In order to switch between the units it's required to change the code which is not flexible.
Details
The humantime library allows us to specify durations in a more human-readable format (e.g., 1s, 2m, 3h). Currently, our configurations use plain numbers (interpreted as seconds), which can be less intuitive and error-prone. This migration will be executed in two distinct phases to ensure smooth transition and maintain compatibility with our existing deployment processes, specifically with Pulumi configurations.
Phase 1: Supporting Both Formats: The primary goal of the first phase is to update the application to support both the existing plain number format and the new humantime format simultaneously. This is crucial for maintaining system stability and ensuring uninterrupted operations during the migration process.
Phase 2: Completing the Migration to humantime: Once all the configurations in the Pulumi repository have been updated to the new humantime format, we will initiate the second phase.
Acceptance criteria
All the config params with Duration-intended types use humantime parser.
The text was updated successfully, but these errors were encountered:
# Description
Fully closes the #2085.
Since DEX solvers are about to migrate to a separate repo, it's a good
time to change the config format. It will be much more difficult later.
# Changes
Use `humantime` to parse `Duration` config params.
## How to test
e2e + staging
## Related Issues
Fixes#2085
Background
Currently, units of config params with the
Duration
type are hard coded and being parsed using custom functions likeduration_from_seconds
. In order to switch between the units it's required to change the code which is not flexible.Details
The humantime library allows us to specify durations in a more human-readable format (e.g., 1s, 2m, 3h). Currently, our configurations use plain numbers (interpreted as seconds), which can be less intuitive and error-prone. This migration will be executed in two distinct phases to ensure smooth transition and maintain compatibility with our existing deployment processes, specifically with Pulumi configurations.
Acceptance criteria
humantime
parser.The text was updated successfully, but these errors were encountered: