Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: missing api endpoint parameters for /quote #2037

Closed
1 task
mfw78 opened this issue Nov 1, 2023 · 1 comment
Closed
1 task

chore: missing api endpoint parameters for /quote #2037

mfw78 opened this issue Nov 1, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mfw78
Copy link
Contributor

mfw78 commented Nov 1, 2023

Background

When debugging milkman-bot and checking API compliance, it was noted that some API calls were being made to the /quote endpoint that aren't documented in openapi.yml.

Details

Document the API endpoints in openapi.yml

Context

#[serde(
rename = "verificationGasLimit",
default = "default_verification_gas_limit"
)]
verification_gas_limit: u64,

Acceptance criteria

  • Additional fields are included in the openapi.yml.
@mfw78 mfw78 added the bug Something isn't working label Nov 1, 2023
Copy link

github-actions bot commented Feb 7, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant