Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Simulator to return block number if errored #2018

Closed
sunce86 opened this issue Oct 26, 2023 · 0 comments · Fixed by #2054
Closed

feat: Simulator to return block number if errored #2018

sunce86 opened this issue Oct 26, 2023 · 0 comments · Fixed by #2054

Comments

@sunce86
Copy link
Contributor

sunce86 commented Oct 26, 2023

Problem

Driver simulators (web3, enso, tenderly) should return block_number in case they errored on access list estimation or gas estimation.

Suggested solution

Enso and Tenderly should have this out of the box, while for web3 we can add simple eth().block(Latest) call before simulation (we do the same in the non-colocated driver).

Additional context

Needed to populate the field #2013 (comment)
@sunce86 sunce86 mentioned this issue Oct 26, 2023
Merged
1 task
@sunce86 sunce86 mentioned this issue Nov 13, 2023
Merged
3 tasks
sunce86 added a commit that referenced this issue Nov 16, 2023
@sunce86
Add block number to simulation error (#2054)
b5a258a 
# Description
Fixes #2018

# Changes
<!-- List of detailed changes (how the change is accomplished) -->

- [ ] Added block number to each simulation failure. The block number is
approximately fetched from the `web3`.
- [ ] Used this block number for `notify` calls
- [ ] Extracted `notify::simulation_failure` as it is important enough
to have it's own function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add block number to simulation error cowprotocol/services
1 participant
@sunce86