Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor Settlement to allow resimulation #2010

Closed
sunce86 opened this issue Oct 23, 2023 · 1 comment
Closed

chore: Refactor Settlement to allow resimulation #2010

sunce86 opened this issue Oct 23, 2023 · 1 comment

Comments

@sunce86
Copy link
Contributor

sunce86 commented Oct 23, 2023

Background

Currently the simulation of settlement is part of the Settlement constructor (encode function). As I tend to agree that successful simulation is needed for a settlement to be valid and exist, we need a way to resimulate settlement because settlement being valid at time X (simulate successfully) is not a guarantee that it will be also valid at time X + y seconds.
Other motivation might come from the (potential) need to resimulate all settlements on each block to have most accurate gas estimations.

Details

Maybe implementing function with a signature of

pub fn resimulate(self, ...) -> Option<Self> {
        // TODO
}
Copy link

github-actions bot commented Feb 9, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant