Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Don't send requests to 1Inch API for unsupported tokens #1932

Closed
2 tasks
MartinquaXD opened this issue Oct 9, 2023 · 1 comment
Closed
2 tasks

feat: Don't send requests to 1Inch API for unsupported tokens #1932

MartinquaXD opened this issue Oct 9, 2023 · 1 comment

Comments

@MartinquaXD
Copy link
Contributor

Problem

For every user requesting a price on CoW Swap we send a request to 1Inch which the protocol has to pay for somehow which can become very expensive.

Suggested solution

According to their docs 1Inch has the /tokens endpoint which returns all tokens that can get routed through 1Inch. This list could be used as a filter to not send request for trades that would not be supported according to that list.

Acceptance criteria

  • keep an up-to-date list of supported tokens in the 1Inch components responsible for price estimates
  • issue an error and bail out early for requests that contain unsupported tokens (effectively not sending any request to the 1Inch API)
@MartinquaXD MartinquaXD changed the title feat: feat: Don't send requests to 1Inch API for unsupported tokens Oct 9, 2023
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant