feat: app data tutorials #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR: 1. Removes CI/CD tests 2. Adds project management / CLA workflows 3. Adds github issues / pull request templates 4. Updates the repo README
alfetopito
reviewed
Jan 5, 2024
content/tutorial/01-simple-orders/02-app-data/02-create-order-app-data/README.md
Outdated
Show resolved
Hide resolved
content/tutorial/01-simple-orders/02-app-data/02-create-order-app-data/README.md
Show resolved
Hide resolved
content/tutorial/01-simple-orders/02-app-data/02-create-order-app-data/app-a/src/lib/run.ts
Show resolved
Hide resolved
| "orderClass": "twap" | ||
| }, | ||
| "quote": { | ||
| "slippageBips": "7500" |
content/tutorial/02-advanced-orders/01-eth-flow/01-create-eth-flow/README.md
Show resolved
Hide resolved
Comment on lines
+46
to
+51
| ## Order meta data | ||
|
|
||
| For analytics purposes, we can add some metadata to the order. | ||
| The metadata is a JSON document that is stored in IPFS and referenced by the order. | ||
| The metadata is optional, but it's recommended to add it. | ||
| After order creation, the metadata will be displayed in [the Explorer](https://explorer.cow.fi/). |
There was a problem hiding this comment.
Should we link to the app-data tutorial here?
There was a problem hiding this comment.
Yep, will do that to de-dupe on the advanced orders!
Comment on lines
+15
to
+16
| // Slippage percent, it's 0 to 100 | ||
| const quote = { slippageBips: '50' } |
There was a problem hiding this comment.
Actually, it's in basis points (bips) witch is percent/100, so from 0 to 10000.
50 -> 0.5%
There was a problem hiding this comment.
Am removing in-line comments in general (as exhaustive comments in the "walkthrough") so this will be taken care of with the advanced orders.
| title: Merkle tree | ||
| --- | ||
|
|
||
| It's trees all the way down. |
Co-authored-by: Leandro <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Notable exceptions: Due to size limitations for including libraries in the
common.zipfor IPFS, uploading the app data document to IPFS is not covered.Implementing this in a more coherent method within the
app-dataSDK would be better (and then with a subsequent tutorial).