fix: add fee zero adjustments to sign/place order examples #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
anxolin
reviewed
Aug 6, 2024
content/tutorial/01-simple-orders/01-order/03-sign-order/README.md
Outdated
Show resolved
Hide resolved
content/tutorial/01-simple-orders/01-order/03-sign-order/README.md
Outdated
Show resolved
Hide resolved
content/tutorial/01-simple-orders/01-order/03-sign-order/app-b/src/lib/run.ts
Outdated
Show resolved
Hide resolved
alfetopito
force-pushed
the
fix/fee-zero
branch
from
5cfccfc to
5f00022
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users are confused due to fee-zero changes.
The sign/order placement tutorial no longer works, as the feeAmount must be set to
0.Changes
Testing
Make sure shared test steps work.