Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling logo #24

Merged
merged 10 commits into from
Jan 8, 2024
Merged

Styling logo #24

merged 10 commits into from
Jan 8, 2024

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Jan 5, 2024 •
edited
Loading

Description

  • Overrides the Svelte logos in both light and dark mode
  • Changes favicon
Screenshot 2024-01-05 at 11 51 54 Screenshot 2024-01-05 at 11 51 39 Screenshot 2024-01-05 at 11 51 26 Screenshot 2024-01-05 at 11 51 19 Screenshot 2024-01-05 at 11 56 52

@vercel Vercel
Copy link

vercel bot commented Jan 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tutorial ✅ Ready (Inspect) Visit Preview Jan 8, 2024 10:10am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024 •
edited
Loading

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

0 out of 2 committers have signed the CLA.
❌ @fairlighteth
❌ @shoom3301
You can retrigger this bot by commenting recheck in this Pull Request

@fairlighteth fairlighteth requested a review from a team January 5, 2024 11:57
alfetopito
alfetopito approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

Only one small concern regarding favicon size

static/favicon.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That big, isn't it?
Could we use a smaller img?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, had overlooked it. Should be fixed now in terms of size.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm

Still 4x bigger
image

But you are the expert. If you are good with that, I'll shut up.

@shoom3301
feat: wallet connect button (#27)
f235da3 
# Description

Replaced automatic wallet connection to manual button click.
There are three cases:
a. Browser doesn't have wallet extensions
b. Wallet is not connected
c. Wallet is conencted

<img width="406" alt="image"
src="https://github.com/cowprotocol/tutorial/assets/7122625/e4cc2d3f-13bc-485d-91ba-a9b2741f97ca">
@mfw78 mfw78 merged commit cd4b34f into main Jan 8, 2024
3 of 4 checks passed
@mfw78 mfw78 deleted the styling-logo branch January 8, 2024 10:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@mfw78 mfw78 mfw78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fairlighteth @alfetopito @mfw78 @shoom3301