Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimisation] fn deleteOrder() has unneeded parameter #30

Open
josojo opened this issue Oct 24, 2022 · 1 comment
Open

[Optimisation] fn deleteOrder() has unneeded parameter #30

josojo opened this issue Oct 24, 2022 · 1 comment

Comments

@josojo
Copy link
Contributor

josojo commented Oct 24, 2022

deleteOrder() has an input variable "quoteId" of the ethflow.Data. And this variable is not needed. We could optimize for gas and take the variable out.

But IMO, it's not worth it, as this would require defining another EthflowOrder library data type and the gas overhead is quite low

@bh2smith
Copy link

Was this parameter introduced for auxiliary or enriched on chain analytical purposes? If so, then I would be in favour of keeping it. Otherwise feel free to remove it. Did you create the issue so someone else (like me) might remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants