You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
deleteOrder() has an input variable "quoteId" of the ethflow.Data. And this variable is not needed. We could optimize for gas and take the variable out.
But IMO, it's not worth it, as this would require defining another EthflowOrder library data type and the gas overhead is quite low
The text was updated successfully, but these errors were encountered:
Was this parameter introduced for auxiliary or enriched on chain analytical purposes? If so, then I would be in favour of keeping it. Otherwise feel free to remove it. Did you create the issue so someone else (like me) might remove it?
deleteOrder() has an input variable "quoteId" of the ethflow.Data. And this variable is not needed. We could optimize for gas and take the variable out.
But IMO, it's not worth it, as this would require defining another EthflowOrder library data type and the gas overhead is quite low
The text was updated successfully, but these errors were encountered: