Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect artifact formats automatically #564

Open
taminomara opened this issue Jul 5, 2021 · 0 comments
Open

Detect artifact formats automatically #564

taminomara opened this issue Jul 5, 2021 · 0 comments
Assignees

Comments

@taminomara
Copy link
Contributor

We could detect format of JSON artifacts automatically by inspecting their contents and looking at presence of certain keys. We could also use artifact source, i.e. etherscan artifacts are always plain ABI.

Not sure if it should be a separate format with its own struct, settings etc., or just a function. If we go with a separate format, I'd think about ArtifactLoader trait.

Also we could implement AbiFormat for plain ABIs, and stop wrapping etherscan response into curly brackets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant