Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support networks with same chain id but different names #545

Open
taminomara opened this issue Jun 23, 2021 · 2 comments
Open

Support networks with same chain id but different names #545

taminomara opened this issue Jun 23, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@taminomara
Copy link
Contributor

taminomara commented Jun 23, 2021 •
edited
Loading

Hardhat deploy supports having different networks with the same chain id. For example, you can have rinkeby and rinkeby-testing. Both are rinkeby, but contract addresses and ABIs can be different.

It may be beneficial to support this in ethcontract-rs.
@taminomara taminomara added the enhancement New feature or request label Jun 23, 2021
@nlordell
Copy link
Contributor

Also, in general, its probably safer to differentiate on chain ID instead of network ID.

Do you know if it uses the chain ID as the differentiating factor, or something else?

@taminomara
Copy link
Contributor Author

Oh yeah, it uses chain id. Sorry, my bad. I'll update the issue.

@taminomara taminomara changed the title Support differentiating networks by ID Support networks with same chain id but different names Jun 23, 2021
@taminomara taminomara mentioned this issue Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlordell @taminomara