Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runtime use of Artifact type #209

Closed
nlordell opened this issue Feb 23, 2020 · 2 comments
Closed

Remove runtime use of Artifact type #209

nlordell opened this issue Feb 23, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@nlordell
Copy link
Contributor

I think ethcontract should create its own runtime representation of contract data instead of using the Truffle artifact representation. I think it would look something like this:

struct Contract {
    pub name: String,
    pub abi: Abi,
    pub deployments: HashMap<String, Address>,
}

Doing this would also allow us to distinguish between what is needed at runtime (contract ABI and networks map) and what is additionally needed at generation time (documentation). Doing this could also simplify some of the contract traits that are currently needed for linking, fetching the deployed contract for a network, and new deployments as they could all operate over this runtime representation.

@nlordell nlordell added this to the 0.6.0 milestone Feb 23, 2020
@nlordell nlordell modified the milestones: 0.6.0, 0.7.0 Mar 31, 2020
@nlordell nlordell added the enhancement New feature or request label May 4, 2020
@nlordell nlordell modified the milestones: 0.8.0, 1.0.0 Jun 29, 2020
@taminomara
Copy link
Contributor

Artifact was renamed to Contract in #512. Is there anything else that we want to do here?

@nlordell
Copy link
Contributor Author

Yeah, lets close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants