Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrderSigningUtils doesn't accept appDataHash and stringified appData #192

Open
mfw78 opened this issue Jan 3, 2024 · 1 comment
Open

OrderSigningUtils doesn't accept appDataHash and stringified appData #192

mfw78 opened this issue Jan 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mfw78
Copy link
Contributor

mfw78 commented Jan 3, 2024

Problem

If one just passes the QuoteRequestResponse object through to the OrderSigningUtils, the following occurs:

invalid hex string (argument="value", value="{\"appCode\":\"Decentralized CoW\",\"environment\":\"prod\",\"metadata\":{\"orderClass\":{\"orderClass\":\"limit\"},\"quote\":{\"slippageBips\":\"50\"},\"referrer\":{\"address\":\"0xcA771eda0c70aA7d053aB1B25004559B918FE662\"}},\"version\":\"0.11.0\"}", code=INVALID_ARGUMENT, version=bytes/5.7.0)

Solution

OrderSigningUtils should be made aware and able to handle itself so it doesn't do this and hashes the correct parts.
@mfw78 mfw78 added the bug Something isn't working label Jan 3, 2024
@mfw78
Copy link
Contributor Author

mfw78 commented Jan 5, 2024

Also, https://github.com/cowprotocol/tutorial/pull/21/files#r1442750959

@mfw78 mfw78 mentioned this issue Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mfw78