Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test poll happy path and not authorized #159

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Test poll happy path and not authorized #159

merged 5 commits into from
Sep 1, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Aug 31, 2023

This PR includes the mocking and testing of the poll method.

For now, only the following tests:

  • Happy path: getTradeableOrderWithSignature doesn't revert, and the order don't have any validation errors
  • Not auth: the owner hasn't authorised the order

image

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

@coveralls
Copy link
Collaborator

coveralls commented Aug 31, 2023 •
edited
Loading

Coverage Status

coverage: 73.747% (+0.5%) from 73.219% when pulling 4e372f8 on test-poll-happy-and-noauth into 1525759 on test-cabinet.

@anxolin anxolin requested review from mfw78 and a team August 31, 2023 18:25
mfw78
mfw78 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a minor question on one of the lines in the test if it could be explained a bit better for maintainers what JS magic happens on that line?

src/composable/ConditionalOrder.spec.ts Outdated Show resolved Hide resolved
@anxolin anxolin force-pushed the test-poll-happy-and-noauth branch from f037e60 to cd63a2b Compare September 1, 2023 12:41
@anxolin anxolin changed the base branch from test-cabinet to main September 1, 2023 12:41
@anxolin anxolin merged commit 05d1dc2 into main Sep 1, 2023
2 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
@alfetopito alfetopito deleted the test-poll-happy-and-noauth branch September 4, 2023 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mfw78 mfw78 mfw78 approved these changes

@alfetopito alfetopito alfetopito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anxolin @coveralls @alfetopito @mfw78