fix: fix order signing

cowprotocol · Nov 22, 2024 · 228f3d7 · 228f3d7
1 parent 3191677
commit 228f3d7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@cowprotocol/cow-sdk",
-  "version": "5.8.0-RC.4",
+  "version": "5.8.0-RC.5",
   "license": "(MIT OR Apache-2.0)",
   "files": [
     "/dist"

diff --git a/src/trading/getOrderTypedData.ts b/src/trading/getOrderTypedData.ts
@@ -3,6 +3,13 @@ import { ORDER_PRIMARY_TYPE, OrderTypedData } from './types'
 import { OrderSigningUtils, UnsignedOrder } from '../order-signing'
 import { SupportedChainId } from '../common'
 
+const EIP712DomainTypes = [
+  { name: 'name', type: 'string' },
+  { name: 'version', type: 'string' },
+  { name: 'chainId', type: 'uint256' },
+  { name: 'verifyingContract', type: 'address' },
+]
+
 export async function getOrderTypedData(
   chainId: SupportedChainId,
   orderToSign: UnsignedOrder
@@ -14,6 +21,7 @@ export async function getOrderTypedData(
     primaryType: ORDER_PRIMARY_TYPE,
     types: {
       [ORDER_PRIMARY_TYPE]: ORDER_TYPE_FIELDS,
+      EIP712Domain: EIP712DomainTypes,
     },
     message: orderToSign,
   }

diff --git a/src/trading/types.ts b/src/trading/types.ts
@@ -25,9 +25,7 @@ interface TypedDataField {
 export interface OrderTypedData {
   domain: TypedDataDomain
   primaryType: typeof ORDER_PRIMARY_TYPE
-  types: {
-    Order: TypedDataField[]
-  }
+  types: Record<string, TypedDataField[]>
   message: UnsignedOrder
 }