Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide watch-tower hints on order creation #75

Open
1 task
mfw78 opened this issue Sep 19, 2023 · 0 comments
Open
1 task

feat: provide watch-tower hints on order creation #75

mfw78 opened this issue Sep 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@mfw78
Copy link
Contributor

mfw78 commented Sep 19, 2023

Problem

When the watch-tower is indexing single orders, it will immediately attempt to poll on the same block at which the order was created. This may not be the desired effect.

Suggested solution

In the create and createWithContext functions within ComposableCoW, in ConditionalOrderCreated, emit the polling hints.

Alternatives considered

Rely on adapted interfaces in #73 to supply the block hints. Effectively the addition of on-creation hints will save one standard block polling cycle for the conditional order.

Additional context

This is only valid for single orders. As setRoot provides a root of many orders, these orders may have different logic, and therefore it's not practicable, or gas efficient to emit events for all orders within indicating when they should be polled.

Acceptance criteria

  • ConditionalOrderCreated event updated to also emit watch tower hints for single orders.
@mfw78 mfw78 self-assigned this Sep 21, 2023
@mfw78 mfw78 added blocked This issue is blocked by some other work and removed blocked This issue is blocked by some other work labels Sep 25, 2023
@mfw78 mfw78 removed their assignment Sep 30, 2023
@mfw78 mfw78 added the enhancement New feature or request label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant