You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the watch-tower is indexing single orders, it will immediately attempt to poll on the same block at which the order was created. This may not be the desired effect.
Suggested solution
In the create and createWithContext functions within ComposableCoW, in ConditionalOrderCreated, emit the polling hints.
Alternatives considered
Rely on adapted interfaces in #73 to supply the block hints. Effectively the addition of on-creation hints will save one standard block polling cycle for the conditional order.
Additional context
This is only valid for single orders. As setRoot provides a root of many orders, these orders may have different logic, and therefore it's not practicable, or gas efficient to emit events for all orders within indicating when they should be polled.
Acceptance criteria
ConditionalOrderCreated event updated to also emit watch tower hints for single orders.
The text was updated successfully, but these errors were encountered:
Problem
When the watch-tower is indexing single orders, it will immediately attempt to poll on the same block at which the order was created. This may not be the desired effect.
Suggested solution
In the
create
andcreateWithContext
functions withinComposableCoW
, inConditionalOrderCreated
, emit the polling hints.Alternatives considered
Rely on adapted interfaces in #73 to supply the block hints. Effectively the addition of on-creation hints will save one standard block polling cycle for the conditional order.
Additional context
This is only valid for single orders. As
setRoot
provides a root of many orders, these orders may have different logic, and therefore it's not practicable, or gas efficient to emit events for all orders within indicating when they should be polled.Acceptance criteria
ConditionalOrderCreated
event updated to also emit watch tower hints for single orders.The text was updated successfully, but these errors were encountered: