Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repetition number should be replaced by their row idx from the events_file ? #18

Open
hyruuk opened this issue Apr 14, 2024 · 1 comment
Assignees

Comments

@hyruuk
Copy link

hyruuk commented Apr 14, 2024

Currently the repetition ID is based on the number of times a level has been completed in a run, but it doesn't give information about when in the run this repetition was played. It might be more informative to use the absolute order within the run instead.

That would require changes to :

  • bk2 filenames
  • events files

If we agree I can proceed with these changes.

@bpinsard
Copy link
Contributor

I think that when one is looking into the structure of a run, the event file is the best place to start with as it includes the timings too. In the event file you have the order of each repetition, and paths to bk2 files. I would advise again just globbing through the bk2s and hoping for the best, it's better to rely on a standardized data format that are the event files. Unless I am missing something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants