CBL-5720 : Enable vector search tests on macOS, linux, and windows #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pasin
commented
May 15, 2024
•
pasin
commented
- Enabled vector search tests on macOS, linux, and Windows.
- Use Vector Search Build 29.
- Fixed Android PR Validation on Github Action.
- Used a newer windows agent that supports AVX2 required by Vector Search Extension.
- Disabled PQ 12-bits test as the tranining size error was fixed after beta-2.
pasin
force-pushed
the
CBL-5720
branch
7 times, most recently
from
ec3837c to
ae1812a
Compare
|
Code Coverage Results:
|
pasin
force-pushed
the
CBL-5720
branch
21 times, most recently
from
bcb190b to
ffbb2c5
Compare
pasin
changed the title
pasin
commented
May 16, 2024
| @@ -25,6 +25,7 @@ jobs: | |||
|
|
|||
| - name: Setup Android SDK | |||
| run: | | |||
| java -version | |||
There was a problem hiding this comment.
This is for knowing what Java version is used.
pasin
commented
May 16, 2024
| @@ -16,7 +16,7 @@ env: | |||
|
|
|||
| jobs: | |||
| build: | |||
| runs-on: macos-latest | |||
| runs-on: macos-12 | |||
There was a problem hiding this comment.
Need to explicitly use macos as the latest mac has a new version of Java that doesn't work with android SDK sdkmanager.
* Enabled vector search tests on macOS, linux, and Windows. * Use Vector Search Build 29. * Fixed Android PR Validation on Github Action.
|
The submodule check will be fixed once C has release/3.2 branch. |
velicuvlad
approved these changes
May 17, 2024
Forgot to remove [VectorSearch].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.