CBL-5500 : Implement Vector Search API #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
force-pushed
the
feature/CBL-5500
branch
8 times, most recently
from
032201d to
0ddcd90
Compare
* Implemented Vector Search API. * Added a sanity test but disabled (Need to implement structure for automated testing).
|
The PR validation failure is due to an error when pushing the code coverage comment to this PR. |
velicuvlad
approved these changes
Mar 22, 2024
| // limitations under the License. | ||
| // | ||
|
|
||
|
|
There was a problem hiding this comment.
Will fix this in the later PR as don't want to wait for another round of PR validation.
Comment on lines
+160
to
+166
| if (config.minTrainingSize < 1) { | ||
| C4Error::raise(LiteCoreDomain, kC4ErrorInvalidParameter, "minTrainingSize must be > 1."); | ||
| } else if (config.maxTrainingSize < 1) { | ||
| C4Error::raise(LiteCoreDomain, kC4ErrorInvalidParameter, "maxTrainingSize must be > 1."); | ||
| } else if (config.minTrainingSize > config.maxTrainingSize) { | ||
| C4Error::raise(LiteCoreDomain, kC4ErrorInvalidParameter, "minTrainingSize must be <= maxTrainingSize."); | ||
| } |
There was a problem hiding this comment.
I like this more, will have to change it in iOS. Maybe is worth adding how we handle the platform checks in the spec to refer back to it for Beta 2 so we have it consistent.
There was a problem hiding this comment.
I would like that to be a bit flexible for each platform developer to decide. We can sync about the error messaging though. We had a common project for sharing error message. You can check with Blake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Vector Search API.
Added a sanity test but disabled (Need to implement structure for automated testing).