Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase romac/channel-upgrade-only with main #177

Conversation

crodriguezvega
Copy link

@crodriguezvega crodriguezvega commented Jan 8, 2024

@romac @Farhad-Shabani Sorry, I just realised that I should have probably targeted the other PR to romac/channel-upgrade-only branch, since that is the one used in the hermes branch that is adding support for channel upgradability. This PR should get the latest of main into the branch.

@Farhad-Shabani
Copy link
Member

@romac @Farhad-Shabani Sorry, I just realised that I should have probably targeted the other PR to romac/channel-upgrade-only branch, since that is the one used in the hermes branch that is adding support for hermes. This PR should get the latest of main into the branch.

No worries at all @crodriguezvega! I was under the impression that revision of ibc-go was tagged, and since we need a new release, I was in the process of cutting a new one to incorporate our latest updates. Thanks for the heads-up 🙂
If that's the case, maybe we should stick with a tagged version of IBC_GO_COMMIT on the main and reconsider (#172). What do you think @romac ?

@romac
Copy link
Member

romac commented Jan 8, 2024

Agreed, if the commit in #172 does not correspond to a tagged release of ibc-go, then let's revert #172.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants