Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-schema feature doesn't enable schemars for Any #252

Closed
rnbguy opened this issue Nov 8, 2024 · 0 comments · Fixed by #253
Closed

json-schema feature doesn't enable schemars for Any #252

rnbguy opened this issue Nov 8, 2024 · 0 comments · Fixed by #253

Comments

@rnbguy
Copy link
Collaborator

rnbguy commented Nov 8, 2024

ibc-proto is now exporting google proto types from tendermint-proto via #242. But it forget to enable corresponding features for tendermint-proto dependency.

json-schema = ["std", "serde", "dep:schemars"]

The above line should be

 json-schema        = ["std", "serde", "tendermint-proto/json-schema", "dep:schemars"] 

This makes the compilation fail at ibc-rs: cosmos/ibc-rs#1375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant