-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
10 additions
and
0 deletions.
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
.changelog/unreleased/breaking-changes/181-event-attribute-bytes.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
- Use the v0.34 definition of `abci.Event` which does not enforce | ||
valid UTF-8 data for its `key` and `value` attributes, specifying | ||
them as `bytes` instead of `string`. ([#180](https://github.com/cosmos/ibc-proto-rs/issues/180)) | ||
|
||
This is required, because ibc-go emits event attributes which are not valid UTF-8, | ||
so we need to use this definition to be able to parse them. | ||
|
||
In Protobuf, `bytes` and `string` are wire-compatible, so doing this strictly increases the amount fo data we can parse. | ||
|
||
See this Hermes PR for background information: https://github.com/informalsystems/hermes/pull/3768 |