Skip to content

Commit

Permalink
Add changelog entry
Browse files Browse the repository at this point in the history
  • Loading branch information
romac committed Jan 22, 2024
1 parent 4713208 commit 8fabad9
Showing 1 changed file with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
- Use the v0.34 definition of `abci.Event` which does not enforce
valid UTF-8 data for its `key` and `value` attributes, specifying
them as `bytes` instead of `string`. ([#180](https://github.com/cosmos/ibc-proto-rs/issues/180))

This is required, because ibc-go emits event attributes which are not valid UTF-8,
so we need to use this definition to be able to parse them.

In Protobuf, `bytes` and `string` are wire-compatible, so doing this strictly increases the amount fo data we can parse.

See this Hermes PR for background information: https://github.com/informalsystems/hermes/pull/3768

0 comments on commit 8fabad9

Please sign in to comment.