-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'my summary' subset to class ages histogram #729
Conversation
@Carifio24, I updated the guidelines sequence and when the layers/LayerToggle appear. Can you please take a look and see if the flow makes sense and if I turned the layers on/off correctly? One issue I've noticed is that if I move beyond this sequence and then back up, there is a rogue extra layer that appears in the layer toggle that doesn't seem to actually exist. I tried explicitly setting which layers I want the toggle to use, but the extra layer appears anyway. Is there a way to prevent this? |
@patudom The extra layer is the subset that the percentage selector creates in order to highlight part of the data - I've updated the layer toggle to ignore that layer. |
@patudom I forgot that my change to ignore the percentage selection layer also required a change to the layer toggle component itself - see cosmicds/cosmicds#359. |
This PR resolves #728 by adding a subset for "my age" to the "my class" histogram, as well as a layer toggle component for the class histogram viewer. The "my age" subset will be hidden when one of the percentage intervals is selected. This relies on cosmicds/cosmicds#356.
@patudom I wasn't sure exactly which guidelines we wanted the layer toggle to be visible on, so feel free to adjust the logic that determines when the layer toggle displays. Also, let me know if I forgot to implement something that we wanted.