Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'my summary' subset to class ages histogram #729

Merged
merged 10 commits into from
Jan 7, 2025

Conversation

Carifio24
Copy link
Member

This PR resolves #728 by adding a subset for "my age" to the "my class" histogram, as well as a layer toggle component for the class histogram viewer. The "my age" subset will be hidden when one of the percentage intervals is selected. This relies on cosmicds/cosmicds#356.

@patudom I wasn't sure exactly which guidelines we wanted the layer toggle to be visible on, so feel free to adjust the logic that determines when the layer toggle displays. Also, let me know if I forgot to implement something that we wanted.

@Carifio24 Carifio24 requested a review from patudom December 20, 2024 21:29
@patudom
Copy link
Contributor

patudom commented Jan 2, 2025

@Carifio24, I updated the guidelines sequence and when the layers/LayerToggle appear. Can you please take a look and see if the flow makes sense and if I turned the layers on/off correctly?

One issue I've noticed is that if I move beyond this sequence and then back up, there is a rogue extra layer that appears in the layer toggle that doesn't seem to actually exist. I tried explicitly setting which layers I want the toggle to use, but the extra layer appears anyway. Is there a way to prevent this?

Screenshot 2025-01-02 at 4 21 21 PM

@Carifio24
Copy link
Member Author

@patudom The extra layer is the subset that the percentage selector creates in order to highlight part of the data - I've updated the layer toggle to ignore that layer.

@Carifio24
Copy link
Member Author

@patudom I forgot that my change to ignore the percentage selection layer also required a change to the layer toggle component itself - see cosmicds/cosmicds#359.

@patudom patudom merged commit 3bbf9a5 into cosmicds:main Jan 7, 2025
@patudom patudom mentioned this pull request Jan 7, 2025
patudom added a commit that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a layer toggle & subset for "my measurement" in class histogram
2 participants