Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes that have fewer students than what we define as "small" should be merged #723

Open
patudom opened this issue Dec 18, 2024 · 5 comments
Assignees
Labels
6. waiting Need another item to be completed first

Comments

@patudom
Copy link
Contributor

patudom commented Dec 18, 2024

Perhaps we want to sent up a flag in the db to mark test classes as such and ignore them

Screenshot 2024-12-18 at 9 21 48 AM
@patudom patudom added the 2. complete soon Non-breaking issue that should be fixed or implemented soon label Dec 18, 2024
@patudom
Copy link
Contributor Author

patudom commented Dec 18, 2024

In case it's helpful for diagnosing this issue, the too small classes break the age ordering. (Jumps from 14 Gyr to 13 Gyr back to 14 Gyr.)

(Also, the 13 Gyr jump is only in the age label for the best fit line. The slider label says 14 Gyr).

Screen.Recording.2024-12-18.at.9.27.31.AM.mov

@Carifio24
Copy link
Member

I think most of these are classes that were made for some testing purpose and that we can ultimately just delete anyways. I set a few that were obviously test classes to me to have test = 1 in the database, but we should go through once we've finished fixing things up and give the class list a final pass.

@patudom
Copy link
Contributor Author

patudom commented Dec 18, 2024

Thanks, @Carifio24. Is the fact that the age in the slider & the age in the best fit line legend don't always match unrelated to this issue?

@Carifio24
Copy link
Member

I believe it should be unrelated, yeah. I'll take a look at that today and see if I can get those to agree.

@patudom
Copy link
Contributor Author

patudom commented Dec 19, 2024

Between the above PR, cosmicds/cds-api#168, and https://github.com/cosmicds/update-hubble-summaries/pull/7, the issue with the mis-matched ages and classes with blank viewers has been resolved.

Will leave this issue open, so we remember to give the class list the final pass Jon mentioned above.

@patudom patudom added 6. waiting Need another item to be completed first and removed 2. complete soon Non-breaking issue that should be fixed or implemented soon labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6. waiting Need another item to be completed first
Projects
None yet
Development

No branches or pull requests

2 participants