Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stages 4 & 5 - differences in age rounding #623

Closed
patudom opened this issue Sep 24, 2024 · 4 comments
Closed

Stages 4 & 5 - differences in age rounding #623

patudom opened this issue Sep 24, 2024 · 4 comments
Assignees
Labels
3. next in queue Fix or implement after 1s and 2s are done

Comments

@patudom
Copy link
Contributor

patudom commented Sep 24, 2024

While going through the story as student 5000, the age I calculated for the best fit galaxy was 13 Gyr, but my data showed up on the id_slider with an age of 14 Gyr. In the age histogram, my data appears as 13 Gyr.

We should make sure that however we are handling rounding of ages, they all give the same values.

Stage 4:
Screenshot 2024-09-24 at 12 34 22 PM

Stage 5:
Screenshot 2024-09-24 at 12 34 38 PM

Screenshot 2024-09-24 at 12 36 11 PM
@Carifio24
Copy link
Member

@patudom What is the student ID from these screenshots? I'm trying to track down the discrepancy and it would be nice to be able to look at those measurements.

@patudom
Copy link
Contributor Author

patudom commented Sep 25, 2024

5000

@Carifio24
Copy link
Member

Ah yeah, that was in your original comment!

@patudom patudom added the 3. next in queue Fix or implement after 1s and 2s are done label Oct 17, 2024
@patudom
Copy link
Contributor Author

patudom commented Dec 20, 2024

We think these were resolved along with #708 and another issue thread I can't find.

@patudom patudom closed this as completed Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. next in queue Fix or implement after 1s and 2s are done
Projects
None yet
Development

No branches or pull requests

2 participants