From 157ed70e2e1b05533593eea82f3cda4e31ccd1c5 Mon Sep 17 00:00:00 2001 From: Boon Kai Date: Thu, 18 Jan 2024 14:42:47 +0800 Subject: [PATCH 1/3] added ENTRY camera for Spirit and Opportunity Added missing camera: ENTRY (Entry, Descent, and Landing Camera) for Spirit and Opportunity, only available on sol 1 --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index fa578a6..cd6f916 100644 --- a/README.md +++ b/README.md @@ -53,6 +53,7 @@ Along with querying by date, results can also be filtered by the camera with whi NAVCAM|Navigation Camera|✔|✔|✔| PANCAM|Panoramic Camera| |✔|✔| MINITES|Miniature Thermal Emission Spectrometer (Mini-TES)| |✔|✔| + ENTRY|Entry, Descent, and Landing Camera| |✔|✔| ## Querying the API From bc66f0b9cbcdfdecda70635f4d832602e9289ebf Mon Sep 17 00:00:00 2001 From: Boon Kai Date: Mon, 22 Jan 2024 16:54:30 +0800 Subject: [PATCH 2/3] added missing camera SUPERCAM_RMI to perseverance --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index cd6f916..a4fcd04 100644 --- a/README.md +++ b/README.md @@ -39,6 +39,7 @@ Along with querying by date, results can also be filtered by the camera with whi REAR_HAZCAM_RIGHT|Rear Hazard Avoidance Camera - Right SKYCAM|MEDA Skycam SHERLOC_WATSON|SHERLOC WATSON Camera + SUPERCAM_RMI|SuperCam Remote Micro Imager #### Other rovers From efd16e0b14c045162b8ffce85c1799ee8dc61c92 Mon Sep 17 00:00:00 2001 From: bk7312 Date: Sat, 3 Feb 2024 15:39:28 +0800 Subject: [PATCH 3/3] added LCAM to perseverance scraper Issue: - API unable to get photos from Perseverance LCAM (Lander Vision System Camera), LCAM only on Sol 0. - LCAM created in db/seeds.rb (line 26) but missing in spec/models/perseverance_scraper_spec.rb Fix: - Added LCAM to perseverance_scraper_spec.rb - Added LCAM to README.md Disclaimer: - I'm not familiar with the codebase/ruby and this fix is based on searching/comparing where the other Perseverance camera names are being called/used. --- README.md | 1 + spec/models/perseverance_scraper_spec.rb | 1 + 2 files changed, 2 insertions(+) diff --git a/README.md b/README.md index a4fcd04..40530df 100644 --- a/README.md +++ b/README.md @@ -40,6 +40,7 @@ Along with querying by date, results can also be filtered by the camera with whi SKYCAM|MEDA Skycam SHERLOC_WATSON|SHERLOC WATSON Camera SUPERCAM_RMI|SuperCam Remote Micro Imager + LCAM|Lander Vision System Camera #### Other rovers diff --git a/spec/models/perseverance_scraper_spec.rb b/spec/models/perseverance_scraper_spec.rb index a045656..8ea8a26 100644 --- a/spec/models/perseverance_scraper_spec.rb +++ b/spec/models/perseverance_scraper_spec.rb @@ -35,6 +35,7 @@ let!(:skycam) { create :camera, rover: perseverance, name: "SKYCAM" } let!(:waston) { create :camera, rover: perseverance, name: "SHERLOC_WATSON" } let!(:supercam) { create :camera, rover: perseverance, name: "SUPERCAM_RMI" } + let!(:lcam) { create :camera, rover: perseverance, name: "LCAM" } before(:each) do allow(scraper).to receive(:collect_links).and_return ["https://mars.nasa.gov/rss/api/?feed=raw_images&category=mars2020&feedtype=json&sol=1"]