Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit :rover_id in photos controller #140

Closed
mtilda opened this issue Apr 1, 2021 · 1 comment
Closed

Permit :rover_id in photos controller #140

mtilda opened this issue Apr 1, 2021 · 1 comment

Comments

@mtilda
Copy link

mtilda commented Apr 1, 2021

I notice when I run a development version of the API, the console outputs Unpermitted parameter: :rover_id when I make a simple request like GET localhost:3000/api/v1/rovers/curiosity/photos?sol=10 via Insomnia. The request successfully serves the data with a status 200, but the red text in my console is concerning. It goes away when I permit :rover_id in photos_controller.rb

Are others experiencing this as well, or is this isolated to me?
@corincerami
Copy link
Owner

Thanks, this was resolved by your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corincerami @mtilda