Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

fleetd: support operators in metadata #1294

Closed
wants to merge 2 commits into from

Conversation

wuqixuan
Copy link
Contributor

@wuqixuan wuqixuan commented Jul 6, 2015

If define metadata in fleet conf, such as "ram=1024", we can
define the operator in [X-Fleet] unit as below:
[X-Fleet]
MachineMetadata=ram>=2048
The operators have been supported: "<=", ">=", "!=", "<", ">", "="
If the operatior are "<=", ">=", "!=", "<", ">", the value should
be integer, otherwise, the unit will never be launched.

Fixes #1143

wuqixuan added 2 commits July 6, 2015 16:52
If define metadata in fleet conf, such as "ram=1024", we can
define the operator in [X-Fleet] unit as below:
[X-Fleet]
MachineMetadata=ram>=2048
The operators have been supported: "<=", ">=", "!=", "<", ">", "="
If the operatior are "<=", ">=", "!=", "<", ">", the value should
be integer, otherwise, the unit will never be launched.

Fixes coreos#1143
@bcwaldon
Copy link
Contributor

bcwaldon commented Jul 9, 2015

  1. I'd like to see the operator == defined (equivalent to the existing =)
  2. we need significant testing of these new operators
  3. both the API and fleetctl need to validate metadata against these new rules

@mwitkow
Copy link
Contributor

mwitkow commented Sep 5, 2015

This would be awesome :)

@osterman
Copy link

osterman commented Jan 5, 2016

Really looking forward to this!

@dongsupark dongsupark force-pushed the master branch 2 times, most recently from 14580b0 to 63b20dc Compare June 22, 2016 10:22
@dongsupark dongsupark force-pushed the master branch 3 times, most recently from 23d4b13 to 6fb1256 Compare July 1, 2016 11:07
@dongsupark dongsupark force-pushed the master branch 2 times, most recently from 54409ab to a1a21b8 Compare July 8, 2016 11:38
@dongsupark
Copy link
Contributor

Closed in favor of #1632. Thanks.

@dongsupark dongsupark closed this Jul 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants