Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix renamed core rcmail class methods #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
CHANGELOG keyboard_shortcuts
============================

RELEASE 2.4.2

- fix bugs caused by obsolete core $rcmail class methods
- include version info in composer.json
- copy image file to elastic skin

RELEASE 2.4.1

- fix composer.json
Expand Down
35 changes: 18 additions & 17 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
{
"name":"cor/keyboard_shortcuts",
"description":"allows some functionality to be handled with the keyboard",
"license":"GPL-2.0",
"homepage":"https://github.com/corbosman/keyboard_shortcuts",
"type": "roundcube-plugin",
"authors": [
{
"name": "Cor Bosman",
"email": "[email protected]",
"homepage": "http://underwa.ter.net",
"role": "Developer"
}
],
"support": {
"email": "[email protected]",
"issues": "https://github.com/corbosman/keyboard_shortcuts/issues"
}
"name": "cor/keyboard_shortcuts",
"description": "allows some functionality to be handled with the keyboard",
"license": "GPL-2.0",
"homepage": "https://github.com/corbosman/keyboard_shortcuts",
"type": "roundcube-plugin",
"authors": [
{
"name": "Cor Bosman",
"email": "[email protected]",
"homepage": "http://underwa.ter.net",
"role": "Developer"
}
],
"support": {
"email": "[email protected]",
"issues": "https://github.com/corbosman/keyboard_shortcuts/issues"
},
"version": "2.4.2"
}
14 changes: 6 additions & 8 deletions keyboard_shortcuts.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@
*
* Enables some common tasks to be executed with keyboard shortcuts
*
* @version 1.4 - 07.07.2010
* @version 2.4.2 2023-03-09
* @author Patrik Kullman / Roland 'rosali' Liebl / Cor Bosman <[email protected]>
* @licence GNU GPL
* @licence GNU General Public License, version 2
* @link https://github.com/corbosman/keyboard_shortcuts
*
**/
/** *
**/

/**
* Shortcuts, list view:
Expand Down Expand Up @@ -102,11 +101,10 @@ function html_output($p) {
$c .= "</div>";

if(!is_object($rcmail->imap)){
$rcmail->imap_connect();
$rcmail->storage_connect();
}
$threading_supported = $rcmail->imap->get_capability('thread=references')
|| $rcmail->imap->get_capability('thread=orderedsubject')
|| $rcmail->imap->get_capability('thread=refs');
$threading_supported = $rcmail->config->get('message-threading');
$threading_supported = !empty($threading_supported);

if ($threading_supported) {
$c .= "<div><h4>".$this->gettext("threads")."</h4>";
Expand Down
2 changes: 1 addition & 1 deletion package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</lead>
<uri>https://github.com/corbosman/keyboard_shortcuts</uri>
<version>
<release>2.0.2</release>
<release>2.4.2</release>
</version>
<license uri="http://www.gnu.org/licenses/gpl-2.0.html">GNU GPLv2</license>
</package>
Binary file added skins/elastic/images/keyboard.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.