Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Expose Tx timestamp. #1144

Open
s3rj1k opened this issue Sep 5, 2024 · 4 comments
Open

Feature: Expose Tx timestamp. #1144

s3rj1k opened this issue Sep 5, 2024 · 4 comments
Labels
enhancement New feature or request v4 Work for v4

Comments

@s3rj1k
Copy link

s3rj1k commented Sep 5, 2024

Consider exposing Timestamp https://github.com/corazawaf/coraza/blob/main/internal/corazawaf/transaction.go#L116 in types.Transaction interface.

@s3rj1k s3rj1k changed the title Expose Tx timestamp. Feature: Expose Tx timestamp. Sep 5, 2024
@fzipi fzipi added the enhancement New feature or request label Oct 5, 2024
@jcchavezs
Copy link
Member

Do you mind elaborating on the reason? What is the use case?

@s3rj1k
Copy link
Author

s3rj1k commented Oct 23, 2024

Do you mind elaborating on the reason? What is the use case?

I was working on TTL based cache for Tx, so having timestamp from actual transaction could benefit by reducing addition calls to time.Now() for getting same information.

@fzipi fzipi added the v4 Work for v4 label Oct 27, 2024
@jcchavezs
Copy link
Member

@s3rj1k this is a legit use case, do you have any code you could share for such a thing?

@s3rj1k
Copy link
Author

s3rj1k commented Nov 6, 2024

Same answer as before, code is not available sadly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v4 Work for v4
Projects
None yet
Development

No branches or pull requests

3 participants