Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[math-classes] Non-commutative (semi)rings #38

Open
urkud opened this issue Nov 30, 2016 · 2 comments
Open

[math-classes] Non-commutative (semi)rings #38

urkud opened this issue Nov 30, 2016 · 2 comments

Comments

@urkud
Copy link

urkud commented Nov 30, 2016

Currently MathClasses defines Ring to be a commutative ring. I propose to rename it to CommutativeRing, and introduce a Ring for non-commutative rings. Are there any objections? If no, I'll prepare a pull request.

@spitters
Copy link
Collaborator

The reason we did so was because we do not have a substantial development of non-commutative rings. I'd like to wait with the change until there is a need for it.
Thanks for the suggestion, though.

@urkud
Copy link
Author

urkud commented Dec 1, 2016

I was going to improve the linear algebra part of math-classes. In particular, it would be nice to just say "linear maps form a ring". Actually, I think that just renaming Ring to CommutativeRing without introducing non-commutative rings is a good thing, because it improves readability for mathematicians not familiar with this library.
BTW, what is the relation between Ring.v (with Ring_theory.v), Ncring.v and Cring.v in stdlib? They define rings in two different ways, and I failed to find conversion between these two versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants