Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigrm-2 regions of light and darkness should have a chance of circular regions of light instead of rectangular #132

Closed
copperwater opened this issue May 28, 2023 · 1 comment
Closed

bigrm-2 regions of light and darkness should have a chance of circular regions of light instead of rectangular #132

copperwater opened this issue May 28, 2023 · 1 comment
Labels
enhancement New feature or addition to existing feature. help wanted Pull requests to implement this fix or feature are welcome!

Comments

@copperwater
Copy link
Owner

Fixed circular regions of light of varying size. Not from objects on the ground, just permanent light as if from a spotlight on the ceiling.
@copperwater copperwater converted this from a draft issue May 28, 2023
@copperwater copperwater added help wanted Pull requests to implement this fix or feature are welcome! enhancement New feature or addition to existing feature. labels May 28, 2023
copperwater added a commit that referenced this issue Jun 23, 2024
@copperwater
Add "random spotlights" lighting variation to partly dark Bigroom
45af15d 
This creates a new variant within the bigrm-2 variant, which are all
about different patterns of darkness on the map. In this one, random
circular regions are lit up and the rest of the room is dark. Had to go
out of my way a bit to implement it so that the lit areas wouldn't
overlap with each other and create misshapen blobs instead of nice
ellipses. I suppose I could have gotten the same effect with less effort
by adding fixed circles of light that are always in the same position,
but it wouldn't have been as good.

Also, this removes the possibility for bigrm-2 to choose no regions of
darkness at all (which results in a room identical to bigrm-1 with none
of its terrain variations, and you already get that from bigrm-1 25% of
the time).

Closes #132
@copperwater
Copy link
Owner Author

Done a while ago on the savebreaking branch.

@github-project-automation github-project-automation bot moved this from Todo to Done in xNetHack 9.0 Features Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or addition to existing feature. help wanted Pull requests to implement this fix or feature are welcome!
Projects
xNetHack 9.0 Features
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@copperwater